Fix multiple hanging edges and zero overlaps #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix multiple hanging edges, add regression tests - Fix zeroes in `overlapCount`, fix tests - Refactor splitting edge
artem-ogre
commented
Oct 4, 2023
| @@ -508,6 +559,8 @@ void Triangulation<T, TNearPointLocator>::insertEdgeIteration( | |||
| polyR.push_back(iVR); | |||
| outerTrisR.push_back(edgeNeighbor(t, iA, iVR)); | |||
| VertInd iV = iA; | |||
| IndexSizeType nChainedHangingEdgesL = 0; | |||
There was a problem hiding this comment.
First part of the bugfix #142
artem-ogre
commented
Oct 4, 2023
| @@ -1633,7 +1630,7 @@ void Triangulation<T, TNearPointLocator>::triangulatePseudopolygonIteration( | |||
| triangles[iParent].neighbors[iInParent] = iT; | |||
| t.neighbors[0] = iParent; | |||
| t.vertices = detail::arr3(a, b, c); | |||
| // needs to be done at the end not to affect finding edge triangles | |||
| setAdjacentTriangle(a, iT); | |||
There was a problem hiding this comment.
Second part of the bugfix #142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix another bug with zeroes in
overlapsfield, fix the tests.